rdblue commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r287494643
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -49,11 +50,19 @@ import org.apache.spark.util.random.RandomSampler
* The AstBuilder converts an ANTLR4 ParseTree into a catalyst Expression,
LogicalPlan or
* TableIdentifier.
*/
-class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with
Logging {
+class AstBuilder(conf: SQLConf)
+ extends SqlBaseBaseVisitor[AnyRef] with Logging with LookupCatalog {
import ParserUtils._
def this() = this(new SQLConf())
+ val defaultCatalog = for {
Review comment:
It is not obvious what this is doing. I prefer using `map` and `flatMap` for
readability.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
