rdblue commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r287498428
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalog/v2/LookupCatalog.scala
##########
@@ -26,27 +28,31 @@ import org.apache.spark.sql.catalyst.TableIdentifier
@Experimental
trait LookupCatalog {
- def lookupCatalog: Option[(String) => CatalogPlugin] = None
+ def lookupCatalog: Option[String => CatalogPlugin] = None
type CatalogObjectIdentifier = (Option[CatalogPlugin], Identifier)
/**
* Extract catalog plugin and identifier from a multi-part identifier.
*/
object CatalogObjectIdentifier {
- def unapply(parts: Seq[String]): Option[CatalogObjectIdentifier] =
lookupCatalog.map { lookup =>
- parts match {
- case Seq(name) =>
- (None, Identifier.of(Array.empty, name))
- case Seq(catalogName, tail @ _*) =>
- try {
- val catalog = lookup(catalogName)
- (Some(catalog), Identifier.of(tail.init.toArray, tail.last))
- } catch {
- case _: CatalogNotFoundException =>
- (None, Identifier.of(parts.init.toArray, parts.last))
- }
- }
+ def unapply(parts: Seq[String]): Option[CatalogObjectIdentifier] = parts
match {
Review comment:
Do these changes need to be done here, or can we do them in a separate
commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
