rdblue commented on a change in pull request #24686: [SPARK-27813][SQL]
DataSourceV2: Add DropTable logical operation
URL: https://github.com/apache/spark/pull/24686#discussion_r287497337
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataSourceV2SQLSuite.scala
##########
@@ -162,4 +162,18 @@ class DataSourceV2SQLSuite extends QueryTest with
SharedSQLContext with BeforeAn
conf.setConfString("spark.sql.default.catalog", originalDefaultCatalog)
}
}
+
+ test("drop table from catalog") {
Review comment:
Nit: naming convention is `LogicalPlanName: case description`, like:
* `"DropTable: basic behavior"`
* `"DropTable: if exists"`
* `"DropTable: when table is missing"`
I think that these should be separate cases, instead of including the second
`DROP TABLE` command below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
