Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3783#discussion_r22622117
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -373,10 +372,12 @@ private[spark] class ExecutorAllocationManager(
* the executor is not already marked as idle.
*/
private def onExecutorIdle(executorId: String): Unit = synchronized {
- if (!removeTimes.contains(executorId) &&
!executorsPendingToRemove.contains(executorId)) {
- logDebug(s"Starting idle timer for $executorId because there are no
more tasks " +
- s"scheduled to run on the executor (to expire in
$executorIdleTimeout seconds)")
- removeTimes(executorId) = clock.getTimeMillis + executorIdleTimeout
* 1000
+ if (executorIds.contains(executorId)) {
+ if (!removeTimes.contains(executorId) &&
!executorsPendingToRemove.contains(executorId)) {
+ logDebug(s"Starting idle timer for $executorId because there are
no more tasks " +
+ s"scheduled to run on the executor (to expire in
$executorIdleTimeout seconds)")
+ removeTimes(executorId) = clock.getTimeMillis +
executorIdleTimeout * 1000
+ }
}
--- End diff --
can you add an else case here with
```
logWarning(s"Attempted to mark unknown executor $executorId idle")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
