Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3783#issuecomment-69106025
Hey @zsxwing thanks for fixing these. I believe points 3, 4, 5 are covered
sufficiently in this PR. I still don't fully understanding (1). What is the
race condition there, and which part of your patch fixes that? As for (2), I
left an inline comment explaining why the original code is written as such, and
why the corresponding change in this PR overlooks another issue.
By the way, in the future it would be good to break this down into multiple
issues and patches. It seems to me that only (2) actually corresponds to
SPARK-4951. Let me know if this is not the case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
