Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3783#discussion_r22622559
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -315,7 +314,7 @@ private[spark] class ExecutorAllocationManager(
private def onExecutorAdded(executorId: String): Unit = synchronized {
if (!executorIds.contains(executorId)) {
executorIds.add(executorId)
- executorIds.foreach(onExecutorIdle)
+ onExecutorIdle(executorId)
--- End diff --
The original rationale for marking other executors as idle is as follows.
If an idle executor (call this executor X) is not removed because the minimum
is reached, we need to mark it idle again when a new executor joins because we
are no longer at the minimum. Otherwise, we may never removed executor X.
The issue here, however, is that executor X could be running a task, in
which case it is no longer idle and we shouldn't mark it as such. This means we
still need to mark it as idle **only** if it is not actually running anything.
Does that make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
