dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL]
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302300020
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -559,29 +560,24 @@ case class HashAggregateExec(
private def enableTwoLevelHashMap(ctx: CodegenContext): Unit = {
if (!checkIfFastHashMapSupported(ctx)) {
if (modes.forall(mode => mode == Partial || mode == PartialMerge) &&
!Utils.isTesting) {
- logInfo("spark.sql.codegen.aggregate.map.twolevel.enabled is set to
true, but"
+ logInfo(s"${SQLConf.ENABLE_TWOLEVEL_AGG_MAP.key} is set to true, but"
+ " current version of codegened fast hashmap does not support this
aggregate.")
}
} else {
isFastHashMapEnabled = true
// This is for testing/benchmarking only.
// We enforce to first level to be a vectorized hashmap, instead of the
default row-based one.
- isVectorizedHashMapEnabled = sqlContext.getConf(
- "spark.sql.codegen.aggregate.map.vectorized.enable", "false") == "true"
+ isVectorizedHashMapEnabled = sqlContext.conf.enableVectorizedHashMap
}
}
private def doProduceWithKeys(ctx: CodegenContext): String = {
val initAgg = ctx.addMutableState(CodeGenerator.JAVA_BOOLEAN, "initAgg")
if (sqlContext.conf.enableTwoLevelAggMap) {
enableTwoLevelHashMap(ctx)
- } else {
- sqlContext.getConf("spark.sql.codegen.aggregate.map.vectorized.enable",
null) match {
- case "true" =>
- logWarning("Two level hashmap is disabled but vectorized hashmap is
enabled.")
- case _ =>
- }
+ } else if (sqlContext.conf.enableVectorizedHashMap) {
+ logWarning("Two level hashmap is disabled but vectorized hashmap is
enabled.")
Review comment:
Yep. This is a correct update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
