dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL] Use ConfigEntry for hardcoded configs in SQL URL: https://github.com/apache/spark/pull/25059#discussion_r302301828
########## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala ########## @@ -26,6 +26,7 @@ import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan import org.apache.spark.sql.catalyst.rules.Rule import org.apache.spark.sql.execution._ import org.apache.spark.sql.execution.vectorized.OnHeapColumnVector +import org.apache.spark.sql.internal.StaticSQLConf Review comment: Can we change like the following if we need only one configuration import? ``` - import org.apache.spark.sql.internal.StaticSQLConf + import org.apache.spark.sql.internal.StaticSQLConf.SPARK_SESSION_EXTENSIONS ``` Then, the other will be shorter. ``` - .config(StaticSQLConf.SPARK_SESSION_EXTENSIONS.key, classOf[MyExtensions].getCanonicalName) + .config(SPARK_SESSION_EXTENSIONS.key, classOf[MyExtensions].getCanonicalName) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
