dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL]
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302303385
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListenerSuite.scala
##########
@@ -647,7 +648,7 @@ class SQLAppStatusListenerMemoryLeakSuite extends
SparkFunSuite {
.setMaster("local")
.setAppName("test")
.set(config.TASK_MAX_FAILURES, 1) // Don't retry the tasks to run this
test quickly
- .set("spark.sql.ui.retainedExecutions", "50") // Set it to 50 to run
this test quickly
+ .set(StaticSQLConf.UI_RETAINED_EXECUTIONS.key, "50") // Set it to 50 to
run this test quickly
Review comment:
```
- .set(StaticSQLConf.UI_RETAINED_EXECUTIONS.key, "50") // Set it to 50
to run this test quickly
+ .set(UI_RETAINED_EXECUTIONS.key, "50") // Set it to 50 to run this
test quickly
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]