dongjoon-hyun commented on a change in pull request #25059: [SPARK-28257][SQL]
Use ConfigEntry for hardcoded configs in SQL
URL: https://github.com/apache/spark/pull/25059#discussion_r302302186
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
##########
@@ -665,17 +666,17 @@ abstract class SQLViewSuite extends QueryTest with
SQLTestUtils {
sql(s"CREATE VIEW view${idx + 1} AS SELECT * FROM view$idx")
}
- withSQLConf("spark.sql.view.maxNestedViewDepth" -> "10") {
+ withSQLConf(SQLConf.MAX_NESTED_VIEW_DEPTH.key -> "10") {
val e = intercept[AnalysisException] {
sql("SELECT * FROM view10")
}.getMessage
assert(e.contains("The depth of view `default`.`view0` exceeds the
maximum view " +
"resolution depth (10). Analysis is aborted to avoid errors.
Increase the value " +
- "of spark.sql.view.maxNestedViewDepth to work around this."))
+ s"of ${SQLConf.MAX_NESTED_VIEW_DEPTH.key} to work around this."))
Review comment:
ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
