cloud-fan commented on a change in pull request #25997: [SPARK-29326][SQL] ANSI store assignment policy: throw exception on casting failure URL: https://github.com/apache/spark/pull/25997#discussion_r330440274
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ########## @@ -274,8 +277,9 @@ case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String override def nullable: Boolean = Cast.forceNullable(child.dataType, dataType) || child.nullable - override def withTimeZone(timeZoneId: String): TimeZoneAwareExpression = - copy(timeZoneId = Option(timeZoneId)) + def withTimeZone(timeZoneId: String): TimeZoneAwareExpression Review comment: ditto ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
