cloud-fan commented on a change in pull request #25997: [SPARK-29326][SQL] ANSI
store assignment policy: throw exception on casting failure
URL: https://github.com/apache/spark/pull/25997#discussion_r330443127
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -36,21 +38,23 @@ import org.apache.spark.unsafe.types.UTF8String
/**
* Test suite for data type casting expression [[Cast]].
*/
-class CastSuite extends SparkFunSuite with ExpressionEvalHelper {
+abstract class CastSuiteBase extends SparkFunSuite with ExpressionEvalHelper {
Review comment:
Can you talk about the rationale of this test refactor? I would keep the
test suite unchanged, and just add a few new test cases for `AnsiCastSuite`.
One day if we have two totally different cast (like `AnsiCast` and
`SafeCast`), then I would refactor the test suite annd test these 2 casts
separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
