cloud-fan commented on a change in pull request #25997: [SPARK-29326][SQL] ANSI 
store assignment policy: throw exception on casting failure
URL: https://github.com/apache/spark/pull/25997#discussion_r330560466
 
 

 ##########
 File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
 ##########
 @@ -36,21 +38,23 @@ import org.apache.spark.unsafe.types.UTF8String
 /**
  * Test suite for data type casting expression [[Cast]].
  */
-class CastSuite extends SparkFunSuite with ExpressionEvalHelper {
+abstract class CastSuiteBase extends SparkFunSuite with ExpressionEvalHelper {
 
 Review comment:
   The tests create `Cast` and check it with ansi mode on and off. How is it 
related to `AnsiCast`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to