cloud-fan commented on a change in pull request #25997: [SPARK-29326][SQL] ANSI
store assignment policy: throw exception on casting failure
URL: https://github.com/apache/spark/pull/25997#discussion_r330999051
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/DataSourceV2AnalysisSuite.scala
##########
@@ -77,57 +77,30 @@ class V2OverwriteByExpressionANSIAnalysisSuite extends
DataSourceV2ANSIAnalysisS
}
test("delete expression is resolved using table fields") {
- val table = TestRelation(StructType(Seq(
- StructField("x", DoubleType, nullable = false),
- StructField("y", DoubleType))).toAttributes)
-
- val query = TestRelation(StructType(Seq(
- StructField("a", DoubleType, nullable = false),
- StructField("b", DoubleType))).toAttributes)
-
- val a = query.output.head
- val b = query.output.last
- val x = table.output.head
-
- val parsedPlan = OverwriteByExpression.byPosition(table, query,
- LessThanOrEqual(UnresolvedAttribute(Seq("x")), Literal(15.0d)))
-
- val expectedPlan = OverwriteByExpression.byPosition(table,
- Project(Seq(
- Alias(Cast(a, DoubleType, Some(conf.sessionLocalTimeZone)), "x")(),
- Alias(Cast(b, DoubleType, Some(conf.sessionLocalTimeZone)), "y")()),
- query),
- LessThanOrEqual(
- AttributeReference("x", DoubleType, nullable = false)(x.exprId),
- Literal(15.0d)))
-
- assertNotResolved(parsedPlan)
- checkAnalysis(parsedPlan, expectedPlan)
- assertResolved(expectedPlan)
+ testResolvedOverwriteByExpression()
}
test("delete expression is not resolved using query fields") {
- val xRequiredTable = TestRelation(StructType(Seq(
- StructField("x", DoubleType, nullable = false),
- StructField("y", DoubleType))).toAttributes)
+ testNotResolvedOverwriteByExpression()
+ }
+}
- val query = TestRelation(StructType(Seq(
- StructField("a", DoubleType, nullable = false),
- StructField("b", DoubleType))).toAttributes)
+class V2OverwriteByExpressionStrictAnalysisSuite extends
DataSourceV2StrictAnalysisSuite {
+ override def byName(table: NamedRelation, query: LogicalPlan): LogicalPlan =
{
+ OverwriteByExpression.byName(table, query, Literal(true))
+ }
- // the write is resolved (checked above). this test plan is not because of
the expression.
- val parsedPlan = OverwriteByExpression.byPosition(xRequiredTable, query,
- LessThanOrEqual(UnresolvedAttribute(Seq("a")), Literal(15.0d)))
+ override def byPosition(table: NamedRelation, query: LogicalPlan):
LogicalPlan = {
+ OverwriteByExpression.byPosition(table, query, Literal(true))
+ }
- assertNotResolved(parsedPlan)
- assertAnalysisError(parsedPlan, Seq("cannot resolve", "`a`", "given input
columns", "x, y"))
+ test("delete expression is resolved using table fields") {
+ testResolvedOverwriteByExpression()
}
-}
-class V2OverwriteByExpressionStrictAnalysisSuite extends
V2OverwriteByExpressionANSIAnalysisSuite {
- override def getSQLConf(caseSensitive: Boolean): SQLConf =
- super.getSQLConf(caseSensitive)
- .copy(SQLConf.STORE_ASSIGNMENT_POLICY -> StoreAssignmentPolicy.STRICT)
Review comment:
shall we keep it? in case we change the default policy later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
