pbacsko commented on code in PR #579:
URL: https://github.com/apache/yunikorn-core/pull/579#discussion_r1259571885
##########
pkg/events/event_system.go:
##########
@@ -38,20 +42,57 @@ type EventSystem interface {
}
type EventSystemImpl struct {
- Store *EventStore // storing eventChannel
- publisher *EventPublisher
+ eventSystemId string
+ Store *EventStore // storing eventChannel
+ publisher *EventPublisher
channel chan *si.EventRecord // channelling input eventChannel
stop chan bool // whether the service is stop
stopped bool
- sync.Mutex
+ trackingEnabled bool
+ requestsEnabled bool
+ requestCapacity int
+ bufferCapacity int
+ responseMaxSize int
Review Comment:
Consider adding comments to these entries. If "bufferCapacity" refers to the
ring buffer, then rename it to "ringBufferCapacity" to make it clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
