wilfred-s commented on code in PR #579: URL: https://github.com/apache/yunikorn-core/pull/579#discussion_r1259010302
########## pkg/common/configs/configs.go: ########## @@ -26,11 +26,34 @@ import ( ) const ( - HealthCheckInterval = "health.checkInterval" + // prefixes + PrefixEvent = "event." + PrefixHealth = "health." + + HealthCheckInterval = PrefixHealth + "checkInterval" + + // events + CMEventRequestsEnabled = PrefixEvent + "requestsEnabled" + CMEventTrackingEnabled = PrefixEvent + "trackingEnabled" + CMEventRequestCapacity = PrefixEvent + "requestCapacity" + CMEventBufferCapacity = PrefixEvent + "bufferCapacity" + CMEventResponseSize = PrefixEvent + "responseMaxSize" + + // defaults + DefaultHealthCheckInterval = 30 * time.Second + DefaultEventRequestsEnabled = false + DefaultEventTrackingEnabled = true + DefaultEventRequestCapacity = 1000 + DefaultEventBufferCapacity = 100000 + DefaultEventResponseSize = 10000 Review Comment: This is not easy to enforce. We need to serialise the data before we know the final size and cannot add or remove anything from that serialised buffer. Think we need to drop this and just use the request capacity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
