craigcondit commented on code in PR #579:
URL: https://github.com/apache/yunikorn-core/pull/579#discussion_r1259635451
##########
pkg/events/event_system.go:
##########
@@ -38,20 +42,57 @@ type EventSystem interface {
}
type EventSystemImpl struct {
- Store *EventStore // storing eventChannel
- publisher *EventPublisher
+ eventSystemId string
+ Store *EventStore // storing eventChannel
+ publisher *EventPublisher
channel chan *si.EventRecord // channelling input eventChannel
stop chan bool // whether the service is stop
stopped bool
- sync.Mutex
+ trackingEnabled bool
Review Comment:
I think the existing name is fine. We actually need to leave the existing
event system always ON as we will be needing those events in the shim for other
purposes (better reporting of predicate checks to K8s for example). Therefore,
trackingEnabled seems to fit -- we are controlling only whether we store events
for retrieval via API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
