craigcondit commented on code in PR #579: URL: https://github.com/apache/yunikorn-core/pull/579#discussion_r1259009836
########## pkg/common/configs/configs.go: ########## @@ -26,11 +26,34 @@ import ( ) const ( - HealthCheckInterval = "health.checkInterval" + // prefixes + PrefixEvent = "event." + PrefixHealth = "health." + + HealthCheckInterval = PrefixHealth + "checkInterval" + + // events + CMEventRequestsEnabled = PrefixEvent + "requestsEnabled" + CMEventTrackingEnabled = PrefixEvent + "trackingEnabled" Review Comment: I think we can just use "event.trackingEnabled" and do away with "requestsEnabled". This was for a legacy feature that wasn't ever fully implemented, so there's no need to support it for backwards compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
