can u test erlands patch? i should start by saying you guys have me at a disadvantage, b/c i don't know the DB or how it works as well as you guys do. but i'll respond as best i can:
JJZolx;638654 Wrote: > Ok, then given the above, this is what I'd propose: > > > > > - SBS, when its scans an album that it determines to be a > compilation, would assign the contributor with the name 'Various > Artists' to the album artist role for the album. It may have to > create this contributor if it doesn't already exist. The lookup > would always be by name and would use the name set in the options > for the VA artist.> > > > i believe this is what it does already, but only in SOME cases. > > it basically only does this, if AA tags are blank / don't exist, and > a user has comp=1 tags and/or artist mismatches. > > i am assuming that the SBS VA naming option, does two things, which > are in fact, one and the same thing. one, it creates the name of the > comp category in SBS, and two it denotes what the SBS DB AA field > entry will be for things SBS calls comps that don't otherwise have AA > tags. again, one seemingly is the same as the other functionally in > the current code. > > > JJZolx;638654 Wrote: > > If there's an album with an explicit ALBUMARTIST=Various Artists, it > > will end up using the same contributor for its album artist role.> > > > or whatever the AA tag value is. > > > JJZolx;638654 Wrote: > > Don't do anything special to sort this contributor to the top of the > > artist list. Allow it to sort at 'V' (or wherever, according to the name > > that is set).> > > > right. or (also) whatever the AA tag says if existing. > > > JJZolx;638654 Wrote: > > Add a 'Browse Compilations' browse mode (make it optional?) for > > those who want it. (Still, this seems very odd to me to have an entire > > browse mode for one particular artist. I don't see why it would be > > necessary.) In this context, a compilation album is merely one that has > > as its album artist the contributor named 'Various Artists' (or its > > substitute). > > > > its not for one artist. home>comps would be a big category for ANYTHING sbs has classified a comp. home>everything else would sort based on SBS DB AA values only, and not comp status. the SBS DB AA values would still be determined when and where necessary by comp logic however, so that part ould be exactly the same as today. what i don't see above in your posts is a solution to the string conflict, but i might be missing it. JJZolx;638654 Wrote: > But we're back again to the slightly sticky problem of what happens when > the name 'Various Artists' is changed in the options. What I see is that > it either requires a full rescan, or else (much faster) SBS would: this might be why a distiction should be made between what the comp category is called, and what value SBS is going to use for AA when no explicit AA tag is available on something SBS otherwise determines is a comp. JJZolx;638654 Wrote: > > > > - Create a new contributor record with this name, unless one > already exists. SBS has to do this because albums with explicit > ALBUMARTIST=Various Artists tags should not have any other name > substituted for the contributor in the album artist role. > - Take all compilation albums and switch their album artist to the > new contributor. Compilation albums in this context would only those > determined by SBS to be a compilation by COMPILATION=1 or artist > makeup. This would require SBS to keep a compilation=1/0 column for > albums. > > The albums.contributor column would also need to be changed for > these albums, so that the sorting of albums by artist would change > with the new name. > > This should require just two simple database queries. > - Delete the contributor with the old name only if there are no > longer any contributor roles using it. If it was something like > 'Various Artists' then you might still have non-compilation albums > where ALBUMARTIST was set to the string. > > > > > > Mostly, this seems easy to do. It does away with the 'special' > contributor that is the VA, although one contributor in the > contributors table will still be used by all compilation albums. It > also eliminates the special sorting, so generating an artist list > should be simpler. > > Because it's possible to rename the VA, it would have to be > determined which takes precedence, the COMPILATION or the ALBUMARTIST > tag. If you have > > ALBUMARTIST=Various Artists > COMPILATION=1 > > I think you'd want the ALBUMARTIST tag to take precedence. personally, i think you're way off the rails with all that, but i could easily be wrong. but i say that b/c it all seems a lot more complex then it needs to be. Erlands patch should be a fix as is. but forget that for a moment. the salient point is that even without Erlands patch, a decent fix would be to have Home>Artists and Home>Albums and so on make those lists WITHOUT ANY CONSIDERATION IN THE CODE to comp status! its a stupid thing for SBS to check to make a displayed list! all those lists should be built off of only SBS DB AA values, and nothing else! why check comp status??? then, you make Home>Comps a new view, and only have things SBS calls comps show up in it. thats the time to check comp status. comps would show up in both places. problem solved! then at the point, you have one option that lets you determine what value SBS will use to call the comp category, and another option to tell SBS what value to use for the SBS DB AA value when no AA tags are present and it detects artist mismatches. finally, you need some kind of way for SBS to figure out whats a comp. it has some already known to us all. Erlands patch adds another needed way. my bug 17031 adds yet another way as well. -- MrSinatra www.lion-radio.org using: sb2 & droid (my home) / duet & ipeng (parents' home) - sbs 7.5.5b - win7 & xp pro sp3 ie9 - p4(ht) 3.2ghz, 2gig ram - 1tb wd usb2 raid1 - d-link dir-655 - 49k+ mp3/flac ::VOTE FOR 'BUG 15604' (http://bugs.slimdevices.com/show_bug.cgi?id=15604)!!!:: ------------------------------------------------------------------------ MrSinatra's Profile: http://forums.slimdevices.com/member.php?userid=2336 View this thread: http://forums.slimdevices.com/showthread.php?t=88072 _______________________________________________ ripping mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/ripping
