Philip Meyer;638733 Wrote:
> >Are we just talking about making the scanner set the compilation flag
> >on an album if the "Various Artists" name configured in SBS settings
> >matches the ALBUMARTIST tag ?
> >
> If people don't want compilation tags, don't frig the code so they get
> them, just to avoid an issue in some other bit of code. It's not the
> right thing to do; quite a fundamental change. Config pref changes
> will require rescan. If someone explicitly doesn't want it to be set.
> I'm not sure what further implications there could be for other browse
> methods, but does that work for iTunesImport and MusicIP scanning?
>
Come on, we are only talking about changing the compilation flag for
albums where ALBUMARTIST has been set to "Various Artists". I'm pretty
sure 99.9% of all users that have an album like this and use the "Group
compilation albums together" setting would want this album under
"Various Artists" in the "Artists" menu. I'm also pretty sure 99.9 % of
them consider it to be a compilation unless they have explicitly set
COMPILATION=0. The patch doesn't do anything if COMPILATION flag is
set.
I think it will work also with iTunesImport and MusicIP as the change
is in Slim::Schema in _createOrUpdateAlbum where all code creating
albums will end up. However, this is why it's important that someone
that actually use iTunesImport or MusicIP tests the patch. It's also
important that someone with MP3 library tires it with the special TPE2
logic as I've only tested it with FLAC with a real ALBUMARTIST tag.
I don't have the time to spend a lot of time testing this myself, so if
no one is willing to test the patch it means it won't be committed by
Logitech, because they have bigger problems to solve in 7.6 than things
like this.
Philip Meyer;638733 Wrote:
>
> A better and potentially low-risk is to change browse menu sql to not
> filter out compilation artist from list of artists in the normal place.
> After all, that's what people are really requesting. The special
> "Various Artists" artist (that only contains compilations) can continue
> to exist at the top of the list.
>
Isn't that what you get already today by selecting "List compilation
albums under each artist" in the SBS settings ?
For me, the main point with "Group compilation albums together" option
is that I don't want artists who only appears on compilation albums in
the artist list.
Removing the compilation=0 filtering will include all artists on
compilation albums in the Artists list, I just tried, so I'm afraid
this will cause a lot worse effects than setting the compilation flag.
As a side note, the Slim::Control::Queries::artistsQuery looks quite
different in 7.6 and 7.5. So if you or anyone else wants to suggest a
change in the browsing code, please look in the 7.6 code as that's what
we realistically can get Logitech to change.
--
erland
Erland Isaksson ('My homepage' (http://erland.isaksson.info))
(Developer of 'many plugins/applets'
(http://wiki.slimdevices.com/index.php/User:Erland). If my answer
helped you and you like to encourage future presence on this forum
and/or third party plugin/applet development, 'donations are always
appreciated' (http://erland.isaksson.info/donate))
------------------------------------------------------------------------
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=88072
_______________________________________________
ripping mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/ripping
