Philip Meyer;639026 Wrote:
>
> I'm not sure that COMPILATION=0 is a valid expression. It's known to
> cause some weird effects in SBS.
>
Ok, if that's the case I'm starting to think that we maybe shouldn't
bother to apply this patch.
Do you know what weird effects COMPILATION=0 causes ?
I assume COMPILATION=0 is the only situation which results in
albums.compilation=0 in the database ?
Philip Meyer;639026 Wrote:
>
> iTunes stores COMPILATION=1 when "Yes" is chosen, otherwise the tag
> doesn't exist.
>
For which file format does iTunes produce COMPILATION=1 ?
I though it just set the unofficial iTunes specific TCMP frame, but
maybe that's only for MP3 files. Of course, I believe the TCMP frame
results in that SBS treats it as a compilation, so maybe that's just
what you meant ?
Philip Meyer;639026 Wrote:
>
> It wouldn't be possible to turn the auto effect off. When logic is
> applied to library, it can't be undone or auto correct the library if
> the pref value changes, so it should force a full library rescan.
> Making changes to tags and rescanning might not update the album
> correctly? I haven't looked at the patch, but potentially it makes a
> rescan slower (does it iterate through all albums individually looking
> for various artists and setting comp=1 as a post-scan operation? is
> that a quick operation?).
>
It's not doing any extra queries nor any extra loops, it's just an if
statement that decides what it should store in albums.compilation, so
I'd be surprised if it had any visible effect on performance.
The patch affects the logic when albums are created during the
scanning, so it's not running in the post scan various artists step.
Actually I believe the special various artists step at the end no
longer exists in 7.6 it was moved to main scanner logic in 7.5 embedded
and that change has now been merged into 7.6.
This is also the reason why I don't want to spend time doing a patch
for 7.5 because the scanning code between 7.5 and 7.6 is so different
so it's worthless to test a patch on 7.5 if it's going to be committed
only in 7.6.
As I look at it we have the following choices:
==========================
1.
Ignore the problem and continue live with it
2.
Make a small fix to the scanner code that auto detects compilations
also based on certain ALBUMARTIST tag values.
3.
Make a bit larger fix that will affect menu structures in the user
interface and "correct" the Artists menu so it doesn't look at the
compilation flag at all and instead just look at the artist roles.
Basically start treating the "Various Artists" entry the same way as
any other album artist and make the "Group compilations together"
option control if track artists should be shown in the "Artists" menu
or not. Compilation albums would get ALBUMARTIST="Various Artists"
either manually through tagging or automatically through existing
compilation detection logic.
4.
Make a much larger fix and restructure the menus so they start to be a
bit more logical. This might be a new "Browse Compilations" menu but it
might also be separate "Browse Album Artists" and "Browse All Artists"
menus. I think we need some prototyping and beta testing for this
before we can decide which way to go.
My feeling is that it's only alternative 1 or 2 that's going to be
acceptable for Logitech for 7.6, alternative 2 is probably not going to
be acceptable unless there are several beta testers that can agree that
it's the right thing to do and it's also only going to be acceptable if
the patch has been tested.
My feeling is also that on longer terms we need alternative 3 and/or 4
to put an end to all these endless discussions regarding compilations
and Various Artists logic, but I think it's unlikely that Logitech is
willing to incorporate something like this in 7.6 with the limited
resources they currently are dedicating to Squeezebox development.
--
erland
Erland Isaksson ('My homepage' (http://erland.isaksson.info))
(Developer of 'many plugins/applets'
(http://wiki.slimdevices.com/index.php/User:Erland). If my answer
helped you and you like to encourage future presence on this forum
and/or third party plugin/applet development, 'donations are always
appreciated' (http://erland.isaksson.info/donate))
------------------------------------------------------------------------
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=88072
_______________________________________________
ripping mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/ripping
