Philip Meyer;639026 Wrote: > >but i don't understand why you think its a bad idea to have things > that > >match the SBS VA naming option string be treated as if they had a > comp=1 > >tag. (erlands patch) > >[/color] > I've already responded elsewhere with a few things that I would be > cautious about (I can't test the patch to see the effects).
other than the niche case, i saw only theory concerns, nothing tangible. i might have missed it, but the niche case was the only tangible objection i saw. Philip Meyer;639026 Wrote: > The "niche" case is real - it would affect me, and does seem logical. I > don't really know how widespread this would be; and perhaps diversity > with different tagging strategies might identify other similar cases > (eg. different styles of music and tagging strategies as a result - > classical music tagging can be quite different, for example?). The > thing is with this case, it might not be possible to avoid the new > auto-logic through changing tags. i agree its real! of course your niche case is real, AND what that means is... get ready for it... YOUR MUSIC FOR THAT NICHE CASE IS HIDDEN RIGHT NOW! bug 9523 hides it just like anything else in conflict. you seem to prefer that then erlands patch, which would reveal it. i don't see the sense in that at all. Philip Meyer;639026 Wrote: > I'm not sure that COMPILATION=0 is a valid expression. iTunes stores > COMPILATION=1 when "Yes" is chosen, otherwise the tag doesn't exist. > It's known to cause some weird effects in SBS. comp tags aren't valid at all imo, but they de facto exist, so i don't see how comp=1 is valid while comp=0 isn't. in any case, SBS supports them, so its moot anyway. (see Phil Leigh? i got your back! :) ) Philip Meyer;639026 Wrote: > It wouldn't be possible to turn the auto effect off. When logic is > applied to library, it can't be undone or auto correct the library if > the pref value changes, so it should force a full library rescan. > Making changes to tags and rescanning might not update the album > correctly? I haven't looked at the patch, but potentially it makes a > rescan slower (does it iterate through all albums individually looking > for various artists and setting comp=1 as a post-scan operation? is > that a quick operation?). valid concerns to a degree, but not more important than keeping SBS from hiding your music. fixing this should clearly be more important than those things. besides, it seems to me that RIGHT NOW without erlands patch, changing that SBS VA naming option would require a full rescan. and if it only goes into 7.6, my guess is that all 7.6 installs from 7.5.x and below will require a full rescan on first install. it really isn't an option many people change often, if ever, anyway. so it shouldn't be that big a deal. Philip Meyer;639026 Wrote: > > >seems to me that scenario is FAR MORE desirable than the one we have > >now. > > > For people affected by it, it may be a desirable change. That doesn't > mean it is needed/desirable to everyone. As a patch, that may be okay > - people can decide if they want it or not. But if added to the code > base, it isn't optional any more. > > Maybe it's just my pedantic hypothetical reasoning due to the nature of > my day job, that I question such things ;-) It just doesn't feel right, > and patches that act as a work-around can detract further from providing > better solutions (whether we would see ANY official work in this area is > doubtful, but if something is added as a partial workaround, the chances > become slightly diminished). i wanted an option to turn off mandatory VA auto detection, (bug 8324) you said no. now you want this to be optional... i got np with that. i think though its a worthy solution to a real problem that needs addressed. i find it kinda irritating that you didn't respond to that point that your niche case is just as affected by 9523 as a normal case is though. is it b/c it then invalidates your niche case as being a valid argument against erlands patch? -- MrSinatra www.lion-radio.org using: sb2 & droid (my home) / duet & ipeng (parents' home) - sbs 7.5.5b - win7 & xp pro sp3 ie9 - p4(ht) 3.2ghz, 2gig ram - 1tb wd usb2 raid1 - d-link dir-655 - 49k+ mp3/flac ::VOTE FOR 'BUG 15604' (http://bugs.slimdevices.com/show_bug.cgi?id=15604)!!!:: ------------------------------------------------------------------------ MrSinatra's Profile: http://forums.slimdevices.com/member.php?userid=2336 View this thread: http://forums.slimdevices.com/showthread.php?t=88072 _______________________________________________ ripping mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/ripping
