>you and I both agree that this bug is best fixed in the browsing code, >for lots of reasons. > Yes, I think we generally agree on many aspects.
>but i don't understand why you think its a bad idea to have things that >match the SBS VA naming option string be treated as if they had a comp=1 >tag. (erlands patch) > I've already responded elsewhere with a few things that I would be cautious about (I can't test the patch to see the effects). The "niche" case is real - it would affect me, and does seem logical. I don't really know how widespread this would be; and perhaps diversity with different tagging strategies might identify other similar cases (eg. different styles of music and tagging strategies as a result - classical music tagging can be quite different, for example?). The thing is with this case, it might not be possible to avoid the new auto-logic through changing tags. I'm not sure that COMPILATION=0 is a valid expression. iTunes stores COMPILATION=1 when "Yes" is chosen, otherwise the tag doesn't exist. It's known to cause some weird effects in SBS. It wouldn't be possible to turn the auto effect off. When logic is applied to library, it can't be undone or auto correct the library if the pref value changes, so it should force a full library rescan. Making changes to tags and rescanning might not update the album correctly? I haven't looked at the patch, but potentially it makes a rescan slower (does it iterate through all albums individually looking for various artists and setting comp=1 as a post-scan operation? is that a quick operation?). >seems to me that scenario is FAR MORE desirable than the one we have >now. > For people affected by it, it may be a desirable change. That doesn't mean it is needed/desirable to everyone. As a patch, that may be okay - people can decide if they want it or not. But if added to the code base, it isn't optional any more. Maybe it's just my pedantic hypothetical reasoning due to the nature of my day job, that I question such things ;-) It just doesn't feel right, and patches that act as a work-around can detract further from providing better solutions (whether we would see ANY official work in this area is doubtful, but if something is added as a partial workaround, the chances become slightly diminished). _______________________________________________ ripping mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/ripping
