On Saturday 08 August 2009, Jani Frilander wrote: > Okay here it comes. It's ugly and should be rejected but works. There was > some problems:
Around here, "works" improves the appearance of any surrounding words considerably. > 1. To get triplet_mode button checkable. The chord_mode is but could not > find where it's done. So ugly workaround with findAction. I think I figured this one out after I had already accepted your solution and committed the patch. You changed the .rc file, but I bet you forgot to rebuild the resource bundle, and you didn't use your modified .rc file. Whenever you change something in data/, you need to run "make qrc" to pick up the changes. I'd like to figure out a way to have our build system do this automatically, but I just haven't sat down to think about it. I'm not really worried about the findAction...setCheckable hack though. I'll leave the line in there, commented out, and we'll try it without the hack and see if it works for everyone else. It works here either way once I thought to rebuild the resource bundle. I actually just thought of that right as I was about to send a previous draft of this message. > 2. Recycling of old code in NotationView. We are not going to have a > statusbar in notation window, are we? I think we will, and it just hasn't been put back in order yet. > 3. isInTripletMode moved from NotationView to NotationWidget. > 3.5 Variable is uninitialized before first button press. I changed m_tripletmode to m_tripletMode and initialized this variable to false in the ctor. I inserted a couple of spaces somewhere. Other than that, it's straight up your patch. You better believe it's useful! Thank you, Janni. This was really the bright spot in an otherwise rotten day. -- D. Michael McIntyre ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Rosegarden-devel mailing list [email protected] - use the link below to unsubscribe https://lists.sourceforge.net/lists/listinfo/rosegarden-devel
