My comment on this: * Findstat does not need such methods to be in sage (anymore), as we actually define our own maps outside of Sage (for the good of FindStat and for the bad of Sage in my opinion) so at least, no one can be accused of being partial
* If a method exists somewhere and has been there for some time, I don't see why it should be removed: I don't see any negative impact of the method being there. The idea of building some kind of global semantic map of relations between combinatorial objects has not been completely dropped out and I still think it would be a good thing to have. In this context, such a method would make sense. About the name, I have no specific opinion. This being said. I have no interest in these methods in particular. I just wanted to make it clear that Findstat was completely our of the debate. Best, Viviane 2014-12-03 12:23 GMT+01:00 Vincent Delecroix <[email protected]>: > Since you are working on it, I really like better > > Graph.connected_components_sizes() > > rather than > > Graph.connected_components_sizes_partition() > > Otherwise you should chage > > Graph.connected_components_number() > > to > > Graph.connected_components_number_integer() > > The output can be sorted to look like a partition but it is not clear > why it should be a Partition instance. I guess that my preference > would be > > def connected_components_sizes(self): > return sorted((len(cc) for cc in self.connected_components()), > reverse=True) > > Vincent > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
