And actually I said some stuff without revisiting what is done in Gentoo and in sage and I am not sure which one is overkill anymore. I inherit cruft from someone else (possibly me in the past). I need to sort it out.
To go back to: Second, in the patch, you write $(LINK) $(LIBTOOL_FLAGS) whereas it seems to me more logical to put $(LIBTOOL_FLAGS) $(LINK) I think libtool is able to figure it regardless of the order. This flag is only used for cygwin in sage. It is then set to “-no-undefined” which is definitely recognised as a special argument for -mode=link and it will be treated specially. But the libtool manual doesn’t say it has to be specified before or after the “linking” command. People are more comfortable with it being part of the linking command I guess. I’d say the way it is done in the patch is the most usual way to do it. François > On 11/10/2016, at 13:26, Victor Shoup <sh...@cs.nyu.edu> wrote: > > Anyway, like I said, I'm pretty much done, modulo a couple > of things that I asked about two posts above. > Hopefully, someone can clarify those points soon, > and then there will be a distribution of NTL that does > not require any patching :-) > > On Monday, October 10, 2016 at 8:16:17 PM UTC-4, François wrote: > Autotools is nicer for a lot of things. sage does patch > to use libtools and I stayed away from that in Gentoo. > The main advantage as far as I am concerned is that it makes > it easier to produce shared libraries, correctly on a variety > of platforms. Just for linux, and OS X, you don’t strictly > need to do that but it is a good investment in the future. > > In that regard the current sage solution is a bit of a halfway point. > You really should couple it with automake and autoconf but that’s > more work. > > But we should have pestered you about make/$(MAKE) a lot more > as it is a much bigger sin ;) > > François > > > On 11/10/2016, at 13:03, Victor Shoup <sh...@cs.nyu.edu> wrote: > > > > First, you are definitely wrong about punch cards. I started programming > > with Fortran on punch cards in the 70s. > > > > Second, a complete transition to auto tools still feels like overkill at > > this point. > > But I agree that it could come one day. > > In any case, I am almost done with all the requested changes. > > I will follow up with a couple of quick questions, though. > > > > On Monday, October 10, 2016 at 5:09:48 PM UTC-4, Dima Pasechnik wrote: > > > > > > On Monday, October 10, 2016 at 9:09:38 PM UTC+1, François wrote: > > On 11/10/16 01:58, Victor Shoup wrote: > > > Another issue. I'm not sure if $(MAKE) is specific to gnu make or if it > > > is universal. > > > In general, I don't want to assume gnu. But I can certainly make this the > > > default, > > > and provide a config variable to override. > > > > I'll have another go at this when you use > > $(MAKE) inside a makefile you are making sure > > that the make command used is the same one that > > you called on the initial makefile. > > > > As other people mentioned it enable parallel make > > to proceed nicely, and in the case where there is > > several make command installed on the system > > you avoid funny things happening. I have AIX > > system which comes with its own posix make > > command. Something like ntl probably require > > gmake (GNU make), calling AIX make in the > > middle is not a good idea. > > > > > > Perhaps the most natural solution would be to change NTL build system so > > that > > it uses the standard autotools chain (autoconf/automake etc), not only > > libtool. > > Given that it uses very few external libraries, it ought to be an easy > > task. > > > > Given that I am perhaps the only person in this thread who learned to > > program using punch cards, > > I am a dinosaur from an earlier period, yet, I look into the future :-) > > > > Dima > > > > > > > > Francois > > > > -- > > You received this message because you are subscribed to the Google Groups > > "sage-devel" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to sage-devel+...@googlegroups.com. > > To post to this group, send email to sage-...@googlegroups.com. > > Visit this group at https://groups.google.com/group/sage-devel. > > For more options, visit https://groups.google.com/d/optout. > > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To post to this group, send email to sage-devel@googlegroups.com. > Visit this group at https://groups.google.com/group/sage-devel. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To post to this group, send email to sage-devel@googlegroups.com. Visit this group at https://groups.google.com/group/sage-devel. For more options, visit https://groups.google.com/d/optout.
