#5093: [with patch, needs review] rewrite fast_float to support more datatypes
------------------------------+---------------------------------------------
Reporter: cwitty | Owner: cwitty
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-3.4.2
Component: basic arithmetic | Keywords:
------------------------------+---------------------------------------------
Comment(by robertwb):
I've ready most of the patch, it looks really good, and works on all my
examples. I'm still digesting it all... One comment I have is that
{{{
sage: from sage.ext.fast_callable import ExpressionTreeBuilder
sage: etb = ExpressionTreeBuilder(vars=['x','y'])
sage: etb.var('z')
Traceback (most recent call last):
File "<ipython console>", line 1, in <module>
File "fast_callable.pyx", line 555, in
sage.ext.fast_callable.ExpressionTreeBuilder.var
(sage/ext/fast_callable.c:3720)
ValueError: list.index(x): x not in list
}}}
could have a better error.
Something else that would be really nice is an option that uses a fast
domain, if it's there, but ignores the domain parameter if it's not.
For elements, we can use the _xxx_ arithmetic operators, skipping
coercion. Also, PY_TYPE_CHECK(x, Element) is potentially slow--it would be
nice to have a "generic" element of the domain so you can do "type(x) ==
type(generic_element) or PY_TYPE_CHECK(x, Element). But perhaps this is
optimization for a later day.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5093#comment:20>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
