#5093: [with patch, needs review] rewrite fast_float to support more datatypes
------------------------------+---------------------------------------------
Reporter: cwitty | Owner: cwitty
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-3.4.2
Component: basic arithmetic | Keywords:
------------------------------+---------------------------------------------
Comment(by jason):
I agree with merging this now, and addressing the above list of unfixed
things in other tickets. I give this positive review based on the
following.
* I've spent a fair amount of time browsing the code and trying examples.
* Some design issues raised are being addressed in other tickets
* The current fast_float is falling back to the old implementation for
non-implemented features (e.g., arbitrary callables, integers, etc.)
* This thing is being doctested all over the place. Nearly every
plotting command is calling it through fast_float, as well as a lot of
other code. Doctests in plot/*.py, plot3d/*.py[x] and fast_callable.pyx
all pass for me on Ubuntu 32-bit and run in roughly the same time as
before the patch (so no serious speed regressions).
* Carl generally writes very good code and is very responsive to fix
issues if they crop up.
* The code is very well documented and doctested
* We will have some time before the next release in which to hammer this
code with a lot more people to expose any other issues.
So with that, positive review! However, it'd be great if robertwb and
ncalexan, at least, could give their approval.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5093#comment:27>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
