#5093: [with patch, needs review] rewrite fast_float to support more datatypes
------------------------------+---------------------------------------------
Reporter: cwitty | Owner: cwitty
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-3.4.2
Component: basic arithmetic | Keywords:
------------------------------+---------------------------------------------
Comment(by cwitty):
I've attached a patch (fast-callable-cleanup.patch, to be applied after
trac5093-fast-callable.patch) that fixes many of the issues raised,
including everything I considered to be a serious bug.
Fixed:
* fast_callable functions with domain=RDF used to return a Python float;
now they correctly return an element of RDF. (If you want a Python float,
you can now use domain=float; this is the default for fast_float.)
* Power expressions with constant integer exponents are handled specially;
this fixes Nick's problem with RIF expressions returning NaN (and probably
lots of other problems).
* fast_callable of a zero multivariate polynomial now returns a zero in
the base ring, instead of a Python int 0.
* some docstrings in sphinxified files were not sphinxified
* misc documentation typos/minor rewording
Not fixed:
* Robert's suggestion: ''an option that uses a fast domain, if it's there,
but ignores the domain parameter if it's not'' (I don't mind the idea, and
the implementation is easy; what should the syntax be? Part of my problem
picking a syntax is that I don't want to promise that a specialized
interpreter is always faster than the Python-object interpreter, so I
don't particularly want to use the word "fast" in any option names.)
* fast_callable on list,tuple,vector,matrix arguments
* any interaction with #5413 (my plan is to wait until either #5093 or
#5413 gets a positive review, then fix the other one to match)
* fast_callable on constant arguments (waiting for a spec from Jason!)
* fast_callable of a zero multivariate polynomial returns a zero of the
base ring, without paying attention to the types of the arguments
I'm hoping the reviewers will agree that the unfixed issues can wait until
later.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5093#comment:22>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
