#13137: upgrade MPIR to 2.6.0
-------------------------------------------------------------------------+--
Reporter: jhpalmieri |
Owner: tbd
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-5.6
Component: packages |
Resolution:
Keywords: mpir spkg |
Work issues:
Report Upstream: N/A |
Reviewers: Jeroen Demeyer
Authors: John Palmieri, Jean-Pierre Flori, Karl-Dieter Crisman |
Merged in:
Dependencies: #13755 |
Stopgaps:
-------------------------------------------------------------------------+--
Comment (by jpflori):
Replying to [comment:67 leif]:
> Replying to [comment:66 leif]:
> > `patches/configure.patch` is pretty unreadable, and as far as I can
see `SPKG.txt`
Yup, IIRC that's just autocrap diff.
>doesn't mention Clang at all (except for John's changelog entry, which
says we shouldn't [or now do not] use it...?).
I don't think we support clang so that comes as no surprise.
By the way I've reportd some time ago the clang problem upstream but I saw
you even proposed fixes, that's great.
> >
>
> In `spkg-install`, we have:
> {{{
> #!sh
>
> Darwin)
> # In some cases (see SAGE_ROOT/spkg/bin/sage-env), on Darwin,
> # CC might be set to clang, but MPIR doesn't seem to build
> # with clang.
> CLANG=`command -v clang`
> GCC=`command -v gcc`
> if [ -n "$CC" ] && [ "$CC" = "$CLANG" ] && [ -n "$GCC" ] ; then
> export CC="$GCC"
> fi
> }}}
>
> Which means we use `$GCC` even if `CC` is set to `clang` (actually, the
output of `command -v clang`) ''if GCC is available'' (more precisely, if
`command -v gcc` is non-empty).
Indeed.
>
> Apart from that these tests are pretty limited [to not say broken] (and
`CC` is always set btw.), that doesn't prevent the use of Clang. So we
should either issue an error message if GCC is not available (while
`command -v gcc` might actually give a link to `clang` :-) ), or we should
fix the build(?) issues with Clang...
I don't really know what the best solution is.
Personally I don't use Apple stuff, so I would be inclined to merge the
current spkg with minimal changes and deal with the clang nightmare in a
later ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13137#comment:69>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
