#5520: [with patch; positive review] implement Pizer's algorithm for computing
Brandt Modules and Brandt Matrices
---------------------------+------------------------------------------------
Reporter: was | Owner: craigcitro
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.1
Component: modular forms | Keywords:
---------------------------+------------------------------------------------
Comment(by robertwb):
I have looked at all the new code in that touches linear algebra (mostly
fast pari conversion and using pari for small examples) and it all looks
very good. Lots of cleanup of old code (e.g. pre-list-comprehension) and
doctests too. I'll second the positive review for this part of the code.
Some notes, but certainly not a blockers: it would be nice to split the
pari declarations so you don't have to do "cdef extern from 'pari/pari.h'"
in two places (and perhaps elsewhere). Also, did you know there is are
mpz_swap and mpq_swap functions (that are much faster than using a tmp and
mpz_set/mpq_set).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5520#comment:27>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
