#14138: some cleanup in sage.combinat.combinat
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: sage-combinat
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha
Authors: Nathann Cohen | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by ncohen):
> > About `min_part=0` - the warning has been present since early 2009.
That's nearly four years. I think it is about time it should either be
allowed to have this ''value 0'' in the parameter, or be deprecated. There
are no doctests/examples in the file which show ''when'' it produces wrong
results. If the user has no idea when this gives correct results or when
it gives wrong results, it should be removed.
>
> As you wish, as long as you promise to support those users that are
using this option,
> in full knowledge of the risks they were taking, when it will actually
be removed.
I can't answer for Punarbasu, but I personally will not. I will not
tolerate bugs in this software because 10 guys who know where the code is
wrong and do not make any effort to fix it would have to change their
personal code.
And there is no reason on earth why I should feel responsible for the
backward compatibility of their code when they do not feel responsible at
all for the bugs they require us to keep in Sage. This might lead
innocents users into very bad situations they have no way to guess.
If it's a problem for you, just create in your branch a patch that
reverses the removal of those functions when it will be deleted. Of course
that will take time to rebase, and you may have to do this often, and
that's a lot of work, but well.. You chosed this development model, didn't
you ?
What is for sure is that we never did.
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14138#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.