#10963: More functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_review
Priority: major | Milestone:
Component: categories | Resolution:
Keywords: | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues:
Dependencies: #11224, #8327, | Commit:
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688 |
-------------------------------------+-------------------------------------
Comment (by nthiery):
I checked Frederic's doctest fixes. Some of them were the expected fixes
in waiting for #9107. Thanks for handling those! The others actually
stemmed from a regression which was revealed by the commutation with
#11688: GradedModules(QQ) was constructed as a join category. I fixed that
(well, it's more like a workaround, but that will do for now) in
:attachment:trac_10963-more_functorial_constructions-graded-modules-fix-
nt.patch, and reuploaded Frederic's patch without the corresponding hunks.
As for the commutation issue in the queue with #12453: this does not
affect this ticket. It just requires to rebase #12453 in the queue, which
I am about to do now. And rerun the tests. Note that this will be for 5.12
since I don't have the latest beta installed though.
Please have a quick look to the updated patches, and set the ticket to
positive review if you are happy!
Time permitting, I'll have a look at #9107 in case we could just get done
with it and avoid Frederics patch altogether, but let's not wait for that.
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:124>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
