#17034: New user interface for orthogonal arrays and a .explain_construction 
method
-------------------------------------+-------------------------------------
       Reporter:  ncohen             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-6.4
      Component:  combinatorial      |   Resolution:
  designs                            |    Merged in:
       Keywords:                     |    Reviewers:  Vincent Delecroix
        Authors:  Nathann Cohen      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  c7eae7de7591d2f8f9c2f4de13396307ac210028
  u/vdelecroix/17034                 |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  positive_review => needs_work


Comment:

 This really should be a `ValueError`:
 {{{
 sage: designs.orthogonal_arrays.largest_available_k(-1)
 ---------------------------------------------------------------------------
 AssertionError                            Traceback (most recent call
 last)
 <ipython-input-1-67d3fe8bb1f0> in <module>()
 ----> 1 designs.orthogonal_arrays.largest_available_k(-Integer(1))

 /usr/local/src/sage-git/local/lib/python2.7/site-
 packages/sage/combinat/designs/orthogonal_arrays.pyc in
 largest_available_k(n, t)
     934     """
     935     from block_design import projective_plane
 --> 936     assert n>=0, "n(={}) was expected to be >=0".format(n)
     937     assert t>=0, "t(={}) was expected to be >=0".format(t)
     938     if n == 0 or n == 1:

 AssertionError: n(=-1) was expected to be >=0
 }}}

 (use `assert` when you ''know'' that a condition must be true, not to
 ''check'' whether a condition is true)

--
Ticket URL: <http://trac.sagemath.org/ticket/17034#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to