#6441: [with patch, needs review] Charpoly (plus adjoint and det)
----------------------------+-----------------------------------------------
Reporter: spancratz | Owner: somebody
Type: defect | Status: new
Priority: minor | Milestone: sage-4.1.1
Component: linear algebra | Keywords: charpoly, division-free
Reviewer: | Author: Sebastian Pancratz
Merged: |
----------------------------+-----------------------------------------------
Comment(by spancratz):
Dear Rob,
Thanks for taking up the review. I am sorry for the delayed reply --- I
was racing at the Tour of Wales for the last five days and am only back in
Oxford now. That said, I'll try to get back to you about all the points
as soon as possible.
1. That makes sense; I just went through the file sage/matrix/matrix2.pyx
and tried to make these changes whenever suitable.
2. I wasn't quite sure about this when writing the comments in the first
place, but when looking at the code I think I saw three different ways to
put this: no inner quotation marks, double inner quotation marks ", and
single inner quotation marks '. Thus I haven't changed this yet.
3. I've removed the periods at the of the error messages. Moreover, I
agree it should be a ValueError instead of an ArithmeticError. I've also
changed this in other methods in the same file, which I didn't changed
before.
4. Again, I went through the whole file and hopefully made suitable
changes.
5. Done.
6. I still need to do this.
7. That makes sense. I still have to do that.
8. Actually, this did not work the last couple of times I tried. The
problem seems to be that SAGE (although it is set up to use the clone
"sage-seb") tries to build the documentation from "sage-main". So while
I'd be happy to build the documentation and check everything is formatted
properly, I don't know how to do this.
9. Sure, I'll do this once I have made all these changes.
Of course, I don't mind the advice at all, thank you very much! Actually,
I think it's much easier to have these points spelled out explicitly at
least once...
I'll try make the suggested changes and attach a new file to this thread
during the next few days.
Many thanks,
Sebastian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6441#comment:6>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
