#6441: [with patch, needs review] Charpoly (plus adjoint and det)
----------------------------+-----------------------------------------------
Reporter: spancratz | Owner: somebody
Type: defect | Status: new
Priority: minor | Milestone: sage-4.1.1
Component: linear algebra | Keywords: charpoly, division-free
Reviewer: | Author: Sebastian Pancratz
Merged: |
----------------------------+-----------------------------------------------
Comment(by spancratz):
Dear Rob,
Thanks for the quick reply. Re cycling, well, I only started at the age of
24, but we'll see ;).
I've attached a new patch to this thread, hopefully that incorporates all
the necessary changes.
Re (3), I've now turned most errors about square matrices into
"ValueError?"s, although when I chased the through inheriting classes, I
noticed that there is somewhat of an inconsistency, where in similar
places any one of ValueError?, ArithmeticError? or TypeError? is being
used.
Re (9), well, all the methods I've written or changed have documentations
and tests attached to them now, although in some files I touched (e.g.
matrix/matrix2.pyx) there are still methods without documentation,
although I didn't change or even look at them and so won't do anything
about this.
Concerning the paper describing the article, I guess one way of reading it
is going through it and trying to understand it. Alternatively, what would
be very easy is to read Algorithm 3.1 and compare that to the
implementation in the patch.
Kind regards,
Sebastian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6441#comment:8>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
