#17108: IncidenceStructure.degree(set={1,2,3})
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.4
Component: combinatorial | Resolution:
designs | Merged in:
Keywords: | Reviewers:
Authors: Nathann Cohen | Work issues:
Report Upstream: N/A | Commit:
Branch: u/ncohen/17108 | f82b9c41095b538a5da29ba015264c24adddc7c4
Dependencies: #17104 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
> surely subset is better (and please, please do not name
variables/parameters set, for Pete's sake...)
It is only a problem in your head, not a problem in the code. With two
lines everything is solved, and the user interface is clearer as a result.
{{{
+ S = set
+ from __builtin__ import set
}}}
That's all it takes.
> And yes, please get rid of `p=` and of `sets_of_size=`.
Too bad, I liked the `sets_of_size` feature.
> but, really, it is totally wrong to have 3 mutually exclusive keyword
parameters
We did almost the same in `PermutationGroup.orbit`. Instead of different
flags we had a `action='OnPoints',action='OnSets', ...`. I would not mind
having `IncidenceStructure.degree(p,type='set')` or `type='point'` but you
would not like it.
> This is not what the keyword parameters are for, they are not poor man
substitutes of function names. No, they are not...
You seem really bothered by what I do with those parameters. Are you
worried that users may find it confusing ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17108#comment:32>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
