#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
       Reporter:  aschilling         |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.6
      Component:  combinatorics      |   Resolution:
       Keywords:  stopgap,           |    Merged in:
  partitions                         |    Reviewers:  Travis Scrimshaw
        Authors:  Anne Schilling     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  39142901893bc0207e8271ccd4772469fe958e0f
  public/ticket/17898                |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_work => positive_review


Comment:

 Bad input is not a bug. Ever.

 If you feel that something needs better documentation (like the
 description of `max_slope` in `Partitions`, then put better documentation,
 not some stopgap which says to everyone that '''''*ANY*''''' time you use
 this class, don't expect correct answers. By having this stopgap, you've
 said just that. It is obviously a horrible thing for Sage.

 Also that first example is correct; it's subtle because of the trailing
 0's, but it is correct.

 You speak of unhealthy amount of stuff into 1 class, but IIRC you've also
 said that (`Di`)`Graph` needs to be one class. If you have a problem with
 this class, then fix it instead of saying nothing works (which is
 completely false).

--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to