#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw
Authors: Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | 39142901893bc0207e8271ccd4772469fe958e0f
public/ticket/17898 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nbruin):
Replying to [comment:4 tscrim]:
> Bad input is not a bug. Ever.
But having an interface that declares some input "bad" and other input
"good" in a way that makes it hard to decide in which category your input
falls is bad design, which is perhaps not a "bug" in the sense that a
specification is not followed, but is certainly a "bug" in that it makes
the interface very hard to use correctly.
As far as I can see, pretty much arbitrary combinations of the input
parameters make sense mathematically. It might just be that they specify
an empty or hard (impossible?) to enumerate set.
Thus, the routine really only provides a partial implementation of the
*suggested* interface.
There are probably plenty of cases (all the ones where other code calls
this routine?) where you *know* your parameters lie inside the "valid"
part of the parameter space. Probably because you know that a certain
easily described subset lies in the "valid" part.
As Nathann suggests, just first test if the parameters are "known good".
If not, either don't accept the parameters (i.e., raise an error) or print
a toned-down warning:
{{{
Warning: IntegerListsLex is called with input parameters for which it is
not guaranteed to produce correct output
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.