#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw
Authors: Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | 39142901893bc0207e8271ccd4772469fe958e0f
public/ticket/17898 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:7 dimpase]:
> Replying to [comment:4 tscrim]:
> > Bad input is not a bug. Ever.
> in your own private code it will only shoot you in the foot.
>
> As it is a non-private function is should check that the input is
correct. Otherwise it has potential to do a lot of damage to other people.
>
> I am sure you would scream "Bug!" upon finding an incorrect Python
expression that Python runs without any warnings.
I would not be screaming bug, but I do agree that it makes it difficult to
debug. However the equivalent of this stopgap is to say when Python starts
up that "Python may evaluate incorrect expressions and may be unreliable".
Would you use Python if that occurred? I wouldn't because I know there are
stable languages (or at least claim to be).
@ncohen Your proposal is not being ignored, but you have brought about
this current state of affairs which needs to be rectified immediately. I
am not going to put my time and work into a "hard" problem which I don't
see any benefit towards. Instead I think what should be done is have the
paths into `IntegerListsLex` (e.g., in `Partitions`) check for bad in put
(if `min_slope >= 0`). However the stopgap needs to be removed
immediately, and then I will review your implementation.
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
