#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw
Authors: Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | 39142901893bc0207e8271ccd4772469fe958e0f
public/ticket/17898 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: positive_review => needs_work
Comment:
Hello Travis,
> Bad input is not a bug. Ever.
When we are not able to write a piece of code that checks whether the
input is bad, I believe that it is a bug.
> If you feel that something needs better documentation [...]
I do not. I believe that the wrong results that this function returns are
dangerous, and that the users should be warned.
I also proposed that you would only change this code to display the
warning in situations that have been checked for correction, and I would
like to know why this does not satisfy you.
> Also that first example is correct; it's subtle because of the trailing
0's, but it is correct.
It is an unexpected output. This example is not, however, the only one I
provided. Perhaps you will accept the other lines as legit bugs?
> You speak of unhealthy amount of stuff into 1 class, but IIRC you've
also said that (`Di`)`Graph` needs to be one class. If you have a problem
with this class, then fix it instead of saying nothing works (which is
completely false).
This is totally unrelated, but since you ask I highly doubt that I ever
suggested that. Indeed, this is the purpose of `GenericGraph`.
I will write to sage-devel in a second to ask for everybody's advice on
this matter. Please, wait for this discussion to take place before setting
this ticket back to `positive_review`.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
