#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw,
Authors: Travis Scrimshaw, | Anne Schilling
Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | 2f7a90d8419ca8d2202b3cb31290e58194f666e3
public/combinat/fix_bad_stopgap-17898| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vbraun):
I think thats enough discussion for this ticket, at least for now its good
enough to warn against !IntegerListsLex from public access. Please open a
followup for input checking.
Anne, Travis: This question is not just about user checking, but also
about catching programming errors. If you want to attract people to the
combinat codebase then it mustn't be a pit of broken glass shards that'll
cut you if you touch something. There is even the design by contract
movement (http://en.wikipedia.org/wiki/Design_by_contract) to turn
pre/postcondition checking into the building blocks of software. I know it
isn't sexy to sit down for a day and add checking. On the other hand,
spending a day later to track down some obscure bug isn't fun either. You
can take on technical debt but eventually you'll have to pay. I know, your
Partition / Crystal / ... code is perfect and only uses !IntegerListsLex
in the correct way... I often thought that about my code, too.
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
