#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw
Authors: Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | 39142901893bc0207e8271ccd4772469fe958e0f
public/ticket/17898 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello Anne,
> Yes, since you wrote the original stopgap, I suggest that you put in the
tests so that the message does not get displayed when the Partition code
is used.
I know that the `Partition` code is used in many places, and I expect that
your crystal code tests it extensively. I have to say, however, that I do
not trust it very much myself: e.g. I wrote #15467 when I noticed that
providing values for 'parts_in', 'starting' and 'ending' lead Sage to
ignore two among the three.
I believe that this code should be rewritten from scratch, carefully, and
more simply (with less combinations of parameters). That would also most
definitely lead to speedups.
> Also, I would strongly suggest that you add a pointer to the
documentation where the limitations of IntegerListsLex is spelled out.
Otherwise the stopgap message seems rather useless. At least then the user
will know how to use the code!
The description of ticket #17548 can be edited to be more informative to
users of `Partitions/Crystal`. This is where the stopgap currently
redirect users.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
