#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw,
Authors: Travis Scrimshaw, | Anne Schilling
Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | f7e2d10938ed6c8ba4f448ff3fde2baae5112642
public/combinat/fix_bad_stopgap-17898| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
Comment:
Last commit fixes some bad branch management on my part. *ahem*
So after some more thought, Jeroen's second example is actually bad input
because the floor condition does not satisfy the `min_slope` condition, so
it is not a bug in that sense. That is what I get for trying to do this as
I'm running out the door.
Now my most recent changes does some fixing and hacking to better handle
things, now it raises some errors on bad input, and has documentation for
the `IntegerListsLexPublic` class (I thought python simply inherited the
docstring like sphinx does). This is more than a fair compromise and
allows Sage to not scare away people from more common functionality.
@ncohen First, look at what you wrote. Second, I just reverted back to
positive review in accordance with my viewpoint. Now I can't make you be a
part of the solution, but I'd appreciate it if stop throwing mud on our
house and expecting us to clean it up by ourselves. Do I have to get
[[https://www.youtube.com/watch?v=Fmjb1mwFyqc|Barney singing here]]?
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
