#17898: Move of stopgap to user level
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw,
Authors: Travis Scrimshaw, | Anne Schilling
Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | ec3405e8913eba4c7ce55b7abe69a4829144a844
public/combinat/fix_bad_stopgap-17898| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by aschilling):
* status: needs_review => positive_review
Old description:
> As documented in #17548 there are no reported bugs related to
> IntegerListsLex. All cases listed on that ticket have non-valid input (as
> documented in the code).
>
> Since the stopgap is not related to any bug and shows up in completely
> unrelated code, where IntegerListsLex is correctly used, for example
> {{{
> sage: K = crystals.KirillovReshetikhin(['D',4,1],1,1)
> /Applications/sage/local/lib/python2.7/site-
> packages/sage/combinat/partition.py:4827:
> ********************************************************************************
> This code contains bugs and may be mathematically unreliable.
> This issue is being tracked at
> http://trac.sagemath.org/sage_trac/ticket/17548.
> ********************************************************************************
> }}}
> and
> {{{
> sage: Partitions(3,max_part=2)
> /Applications/sage/local/lib/python2.7/site-
> packages/sage/combinat/partition.py:6622:
> ********************************************************************************
> This code contains bugs and may be mathematically unreliable.
> This issue is being tracked at
> http://trac.sagemath.org/sage_trac/ticket/17548.
> ********************************************************************************
> Partitions of 3 having parts less than or equal to 2
> }}}
> it should be moved to the user interface level, which is done in this
> ticket.
New description:
Currently the stopgap on IntegerListsLex pops up in many functions and
classes, where IntegerListsLex is used in the correct parameter range.
This ticket moves the stopgap to the user level and implements further
checks on the validity of the input parameters for IntegerListsLex.
Here are examples where the message currently appears without reference to
IntegerListsLex:
{{{
sage: K = crystals.KirillovReshetikhin(['D',4,1],1,1)
/Applications/sage/local/lib/python2.7/site-
packages/sage/combinat/partition.py:4827:
********************************************************************************
This code contains bugs and may be mathematically unreliable.
This issue is being tracked at
http://trac.sagemath.org/sage_trac/ticket/17548.
********************************************************************************
}}}
and
{{{
sage: Partitions(3,max_part=2)
/Applications/sage/local/lib/python2.7/site-
packages/sage/combinat/partition.py:6622:
********************************************************************************
This code contains bugs and may be mathematically unreliable.
This issue is being tracked at
http://trac.sagemath.org/sage_trac/ticket/17548.
********************************************************************************
Partitions of 3 having parts less than or equal to 2
}}}
--
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:60>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
