#17898: Removal of wrong stopgap
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.6
Component: combinatorics | Resolution:
Keywords: stopgap, | Merged in:
partitions | Reviewers: Travis Scrimshaw,
Authors: Travis Scrimshaw, | Anne Schilling
Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | f7e2d10938ed6c8ba4f448ff3fde2baae5112642
public/combinat/fix_bad_stopgap-17898| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by aschilling):
> From this point of view, the idea of a stopgap is pretty mild: we could
actually be discussing ripping all of this code out of Sage until its
documentation, and probably its input checking, is in good shape. We
shouldn't rip it out, of course, but this part of Sage definitely needs
work.
John, I completely agree with you, this code is not in good shape. Instead
of implementing input checking, I think one should probably rewrite it
from scratch. However, this ticket is about the stopgap itself. The
current message it displays is not really useful, especially when it pops
up in code that uses IntegerListsLex in seemingly valid regions. The
message does not even say that the culprit is IntegerListsLex or points
the user to the documentation. That's what I thought this ticket should
address. I agree in the long run some of us should rewrite IntegerListsLex
completely!
The good thing is that this whole discussion brings up many of the issues
with the IntegerListsLex code.
Best,
Anne
--
Ticket URL: <http://trac.sagemath.org/ticket/17898#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
