#6491: [with spkg, needs review] Modular Cohomology Rings of Finite p-Groups
-------------------------------+--------------------------------------------
Reporter: SimonKing | Owner: SimonKing
Type: enhancement | Status: assigned
Priority: major | Milestone: sage-4.1.1
Component: optional packages | Keywords: cohomology ring finite p-group
Reviewer: | Author: Simon King
Merged: |
-------------------------------+--------------------------------------------
Comment(by wdj):
1.
{{{
I see. You are right, I should put the code for CohomologyRing? into a
different file (say, cohomology_constructor.py), so that init.py only
contains the import statement "from
pGroupCohomology.cohomology_constructor import CohomologyRing?". In that
way, it is still possible for the user to do "from pGroupCohomology import
CohomologyRing?". OK, I will do so.
}}}
You didn't do this, as far as I can tell.
2. There is no indication that I can find that you got permission to
license meataxe as GPLv2+.
3. The package is (IMHO) very disorganized. Files are scattered over
various directories without rhyme or reason. I cannot find a guide in the
docs as to how the unpacking is done, so one can find the source and read
it if one desired details on the algorithms implemented. (For example, why
not just put everything in python2.6/site-packages?)
4. I cannot find the test files spkg-check in the sage tree. Or do you
expact people who want to run tests to download your package and unpack it
separately (as I did before)?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6491#comment:32>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
