#18972: twographs and Seidel switching
-------------------------------------+-------------------------------------
       Reporter:  dimpase            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  graph theory       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:  Nathann Cohen
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dimpase/seidelsw                 |  a729b27245f217f98bde11e4fc13dd03cdce9c96
   Dependencies:  #18960, #18948,    |     Stopgaps:
  #18988, #18991, #18986, #19018,    |
  #19019                             |
-------------------------------------+-------------------------------------

Comment (by dimpase):

 Replying to [comment:133 ncohen]:
 >
 > - very long lines in the doc of `is_twograph_descendant`, `twograph`,
 and
 >   `complement`.

 what is the guideline? 80 chars, less, more?

 >
 > - I also wonder about `TwoGraph.__init__`: what is the best behavior for
 this
 >   class which inherits from `IncidenceStructure`? Should all (existing)
 >   arguments of `IncidenceStructure.__init__` appear in
 `TwoGraph.__init__`, or
 >   should we use `**kwargs` instead? If some argument in
 `IncidenceStructure` is
 >   added/removed, or if the default value changes, then we will very
 probably
 >   "forget" to update `TwoGraph.__init__` as a result.
 Removing will cause a doctest failure, hopefully...

 How does one mix `**kwargs` and explicit keywords (which have to be used
 too, as I need
 some control over this)?

--
Ticket URL: <http://trac.sagemath.org/ticket/18972#comment:134>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to