#18972: twographs and Seidel switching
-------------------------------------+-------------------------------------
Reporter: dimpase | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.9
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dimpase/seidelsw | a729b27245f217f98bde11e4fc13dd03cdce9c96
Dependencies: #18960, #18948, | Stopgaps:
#18988, #18991, #18986, #19018, |
#19019 |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Helloooo again Dima,
Thank you for what you just did. I am not even against the idea of moving
all
class constructors to the catalogs, but so far it is not done this way and
I do
not want it to be done without collective agreement that it is what should
be
done. So I'll not even fight against the idea in this debate.
About your branch, I noticed several last things:
- very long lines in the doc of `is_twograph_descendant`, `twograph`, and
`complement`.
- I also wonder about `TwoGraph.__init__`: what is the best behavior for
this
class which inherits from `IncidenceStructure`? Should all (existing)
arguments of `IncidenceStructure.__init__` appear in
`TwoGraph.__init__`, or
should we use `**kwargs` instead? If some argument in
`IncidenceStructure` is
added/removed, or if the default value changes, then we will very
probably
"forget" to update `TwoGraph.__init__` as a result.
AAAAnd then we should be done with this ticket, at long long last..
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/18972#comment:133>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
