#7109: [with patch, needs review] polyhedra bugs with linearities, rewrite
proposal
---------------------------+------------------------------------------------
   Reporter:  vbraun       |       Owner:  mhampton    
       Type:  enhancement  |      Status:  needs_review
   Priority:  major        |   Milestone:  sage-4.3.2  
  Component:  geometry     |    Keywords:  polyhedra   
     Author:               |    Upstream:  N/A         
   Reviewer:               |      Merged:              
Work_issues:               |  
---------------------------+------------------------------------------------

Comment(by vbraun):

 I looked through the patch and it looks pretty good! Some minor changes:

  * Beautified documentation
  * Made clear that ieqs() is an alias for inequalities().
  * Fixed the crash _init_from_cdd_output() for the input
    sage: p = Polyhedron(ieqs = [[0,1,0,0],[0,0,1,0]])
  * Renamed the generator for incident V-representation objects from
    Hrepresentation.facet() to Hrepresentation.incident(). Wrote the
    analogous Vrepresentation.incident()
  * Added aliases Hrepresentation.adjacent() for
    Hrepresentation.neighbors() and Vrepresentation.adjacent() for
    Vrepresentation.neighbors()
  * Hrepresentation now accepts an optional argumment:
    Hrepresentation(i) now returns Hrepresentation()[i]. same with
 Vrepresentation
  * Rewrote facial_adjacencies(), facial_incidences(),
    vertex_adjacencies(), vertex_incidences() to make use of the
    Hrepresentation/Vrepresentation objects.
  * Equation._repr_() fixed.

 As far as I am concerned, this is now ready for inclusion in sage.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7109#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to